Add better localize keys typings for config pages #17815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
force-pushed
the
localize_keys_typings
branch
from
5b9375f
to
2d63913
Compare
piitaya
changed the title
piitaya
changed the title
bramkragten
reviewed
Sep 4, 2023
bramkragten
reviewed
Sep 4, 2023
src/panels/config/automation/trigger/types/ha-automation-trigger-calendar.ts
Outdated
Show resolved
Hide resolved
…er-calendar.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bramkragten
reviewed
Sep 4, 2023
| @@ -59,7 +68,7 @@ export class HaConfigLovelaceDashboards extends LitElement { | |||
| "ui.panel.config.lovelace.dashboards.picker.headers.icon" | |||
| ), | |||
| type: "icon", | |||
| template: (icon, dashboard) => | |||
| template: (icon: DataTableItem["icon"], dashboard: DataTableItem) => | |||
There was a problem hiding this comment.
Instead, set the type of columns to DataTableColumnContainer<DataTableItem>, it makes the extra typing of dashboard unneeded
There was a problem hiding this comment.
I tried to infer the first parameter by improving the DataTableColumnContainer type but I did not succeed because we can have custom key and this parameter can be undefined. I wonder if we can just drop the first one and keep the second one only (DataTableItem). I will be less confusing to use.
This reverts commit f12f9c0.
bramkragten
approved these changes
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve typings for come config pages :
I also dropped thingtalk unused files and removed some not needed localize exclusions.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: