Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use report errors instead of strict for template subscription #17824

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

bramkragten
Copy link
Member

Proposed change

Disables strict mode from template dev tools, making it behave the same as the core template handling.

Needs: home-assistant/core#99572

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

piitaya
piitaya previously approved these changes Sep 5, 2023
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the front-end changes. It can merged if core merged.
You only need to check with core team what do we do with multiple errors.

@bramkragten bramkragten added this to the 2023.9 milestone Sep 5, 2023
@bramkragten bramkragten merged commit 3c48157 into dev Sep 6, 2023
9 checks passed
@bramkragten bramkragten deleted the use-report-errors-instead-of-strict branch September 6, 2023 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants