[routing-utils] Add missing fields (vercel#6872)

* chore: add missing fields * Update types.ts * Update types.ts * chore add missing as part of the schema * test: add missing case
honuuk · Oct 21, 2021 · 981a76f · 981a76f
1 parent c35c054
commit 981a76f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/packages/routing-utils/src/schemas.ts b/packages/routing-utils/src/schemas.ts
@@ -154,6 +154,7 @@ export const routesSchema = {
             type: 'number',
           },
           has: hasSchema,
+          missing: hasSchema,
         },
       },
       {
@@ -194,6 +195,7 @@ export const rewritesSchema = {
         maxLength: 4096,
       },
       has: hasSchema,
+      missing: hasSchema,
     },
   },
 } as const;
@@ -232,6 +234,7 @@ export const redirectsSchema = {
         maximum: 999,
       },
       has: hasSchema,
+      missing: hasSchema,
     },
   },
 } as const;
@@ -273,6 +276,7 @@ export const headersSchema = {
         },
       },
       has: hasSchema,
+      missing: hasSchema,
     },
   },
 } as const;

diff --git a/packages/routing-utils/src/types.ts b/packages/routing-utils/src/types.ts
@@ -32,6 +32,7 @@ export type Source = {
   important?: boolean;
   status?: number;
   has?: HasField;
+  missing?: HasField;
   locale?: {
     redirect?: Record<string, string>;
     cookie?: string;
@@ -83,6 +84,7 @@ export interface Rewrite {
   source: string;
   destination: string;
   has?: HasField;
+  missing?: HasField;
 }
 
 export interface Redirect {
@@ -91,12 +93,14 @@ export interface Redirect {
   permanent?: boolean;
   statusCode?: number;
   has?: HasField;
+  missing?: HasField;
 }
 
 export interface Header {
   source: string;
   headers: HeaderKeyValue[];
   has?: HasField;
+  missing?: HasField;
 }
 
 export interface HeaderKeyValue {

diff --git a/packages/routing-utils/test/index.spec.js b/packages/routing-utils/test/index.spec.js
@@ -95,6 +95,9 @@ describe('normalizeRoutes', () => {
           { type: 'query', key: 'authorized', value: 'yup' },
           { type: 'host', value: 'vercel.com' },
         ],
+        missing: [
+          { type: 'header', key: 'x-middleware-subrequest', value: 'secret' },
+        ],
       },
     ];