Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump Ferrum/Chrome timeouts #645

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

dentarg
Copy link
Contributor

@dentarg dentarg commented Jul 14, 2024

This error is common in CI:

  1) Error:
BroadcastsTest#test_Message_broadcasts_with_renderable:_render_option:
Ferrum::ProcessTimeoutError: Browser did not produce websocket url
within 10 seconds, try to increase `:process_timeout`. See
https://github.com/rubycdp/ferrum#customization

Example: https://github.com/hotwired/turbo-rails/actions/runs/9919129989/job/27404623838#step:4:230

It is possible to control this timeout (and another one) via ENV vars: https://github.com/rubycdp/ferrum/blob/v0.15/lib/ferrum/browser/options.rb#L10-L11

"timeout" is

The number of seconds we'll wait for a response when communicating with browser. Default is 5.

"process_timeout" is (defaults to 10)

How long to wait for the Chrome process to respond on startup.

Both ferrum CI and cuprite CI has the timeouts set to 25 and 15:

This error is common in CI:

      1) Error:
    BroadcastsTest#test_Message_broadcasts_with_renderable:_render_option:
    Ferrum::ProcessTimeoutError: Browser did not produce websocket url
    within 10 seconds, try to increase `:process_timeout`. See
    https://github.com/rubycdp/ferrum#customization

Example: https://github.com/hotwired/turbo-rails/actions/runs/9919129989/job/27404623838#step:4:230

It is possible to control this timeout (and another one) via ENV vars:
https://github.com/rubycdp/ferrum/blob/v0.15/lib/ferrum/browser/options.rb#L10-L11

"timeout" is

> The number of seconds we'll wait for a response when communicating with browser. Default is 5.

"process_timeout" is (defaults to 10)

> How long to wait for the Chrome process to respond on startup.

Both ferrum CI and cuprite CI has the timeouts set to 25 and 15:

* https://github.com/rubycdp/ferrum/blob/19767d0885afbebc95574eda685e04dc9da2b47d/.github/workflows/tests.yml#L16-L18
* https://github.com/rubycdp/cuprite/blob/373b894d723bf9fb1afe31781963fe655a177218/.github/workflows/tests.yml#L16-L18
@brunoprietog
Copy link
Contributor

Thanks @dentarg!

@brunoprietog brunoprietog merged commit 4f54481 into hotwired:main Jul 15, 2024
15 checks passed
@dentarg dentarg deleted the ci/bump-ferrum-timeouts branch July 15, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants