Introduce support for GitHub wiki search #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/github_wiki
branch
from
9ec7573
to
cdbcdf9
Compare
|
Tagging @kellegous, who is apparently the holder of merges here. |
|
This seems reasonable. I hope to clean up this URL munging on the client-side sometime in the future. I'm going to try this out soon and then I'll get it merged. |
Simplistic approach in supporting GitHub wiki via frontend replacements of paths. Requires a non-default `url-pattern/base-url` in configuration file. Refs hound-search#150
miketheman
force-pushed
the
miketheman/github_wiki
branch
from
cdbcdf9
to
ba8c2f8
Compare
avleen
added a commit
that referenced
this pull request
Oct 23, 2015
Introduce support for GitHub wiki search
|
Tried it out, seems to work without breaking anything. Will merge as it seems pretty useful! |
|
Thanks @avleen, I forgot to merge this. |
|
No problem @kellegous! Got your back, you've been busy :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplistic approach in supporting GitHub wiki via frontend replacements
of paths.
Requires a non-default
url-pattern/base-urlin configuration file.Refs #150
I thought about going one step further and having the default use case detect if the url passed is a wiki or not, but that seemed to go deeper into changing this code and it seemed like keeping the change simple was a better approach.