Handle '+' as space in URI #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traditional URI encoding uses '+' instead of '%20' to represent spaces in URI parameters, but the decodeURIComponent method does not recognize this representation. This is significant because Chrome's "Manage Search Engines" settings page, which lets users add arbitrary search engines as shortcuts in that browser's location bar, represents spaces using the '+' character. So, if you try to add a local Hound instance to your Chrome search engines, any multi-word search will be replaced by a weird regular expression, as the '+' characters will be retained in the search box. For instance, without this change, if you were to set 'hound' as the shortcut term, then entering 'hound some thing' will send the search parameter '?q=some+thing' to Hound, resulting in a search for the regular expression /some+thing/, matching 'something', 'someething', 'someeeeeeeeething', etc. Regular expression search is not affected by this change, because an actual "+" character entered using this Chrome feature will be encoded as %2B, and the '+' will appear in Hound's search box correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traditional URI encoding uses '+' instead of '%20' to represent
spaces in URI parameters, but the decodeURIComponent method
does not recognize this representation.
This is significant because Chrome's "Manage Search Engines"
settings page, which lets users add arbitrary search engines
as shortcuts in that browser's location bar, represents spaces
using the '+' character. So, if you try to add a local Hound
instance to your Chrome search engines, any multi-word search
will be replaced by a weird regular expression, as the '+'
characters will be retained in the search box.
For instance, without this change, if you were to set 'hound'
as the shortcut term, then entering 'hound some thing' will
send the search parameter '?q=some+thing' to Hound, resulting
in a search for the regular expression /some+thing/, matching
'something', 'someething', 'someeeeeeeeething', etc.
Regular expression search is not affected by this change,
because an actual "+" character entered using this Chrome
feature will be encoded as %2B, and the '+' will appear in
Hound's search box correctly.