Support linking to bitbucket style URLs #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitbucket style URLs differ from github style URLs in two ways:
1) The bitbucket SSH repository URL takes the form of:
`ssh://hg@bitbucket.org/username/Foo` (vs
`git@github.com:username/Foo.git`)
2) Direct links to source file lines require the commit hash/revision
id, following this pattern: `{url}/src/{rev}/{path}{anchor}`.
The patch addresses both these concerns to allow for direct file
linking to bitbucket.
This required a change to bubble up the revision to the UI layer, which
can be then fed in to the `UrlToRepo` function for final formatting via
a custom `url-pattern` (as defined above).
Server side, the `revision` value is bound to each `index` upon
opening. The `index.Search` function returns this value in the
`SearchResults` struct.
| @@ -57,7 +59,7 @@ type ExcludedFile struct { | |||
| } | |||
|
|
|||
| func (s Snapshot) Open() (*Index, error) { | |||
| return Open(string(s)) | |||
| return Open(string(s), "") | |||
There was a problem hiding this comment.
This would be problematic if we still used this notion of a Snapshot, but we don't. So I'm going to merge your change and then fix this in a separate change.
There was a problem hiding this comment.
Ah yes, thanks for spotting that. I had originally ripped it out, but put it back in just in case I was missing something... and forgot to follow up on it.
|
Thanks for fixing this. |
kellegous
added a commit
that referenced
this pull request
Mar 8, 2015
Support linking to bitbucket style URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket style URLs differ from github style URLs in two ways:
ssh://hg@bitbucket.org/username/Foo(vsgit@github.com:username/Foo.git)id, following this pattern:
{url}/src/{rev}/{path}{anchor}.This patch addresses both these concerns to allow for direct file
linking to bitbucket.
This required a change to bubble up the revision to the UI layer, which
can be then fed in to the
UrlToRepofunction for final formatting viaa custom
url-pattern(as defined above).Server side, the
revisionvalue is bound to eachindexuponopening. The
index.Searchfunction returns this value in theSearchResultsstruct.