Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the Datsource.connection.update() functionality #57

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

JustinGrilli
Copy link
Collaborator

@JustinGrilli JustinGrilli commented Jul 6, 2023

Summary

Currently updating the Datsource.connection will not update the caption of the NamedConnection object.
image
The NamedConnection.caption should match the Connection.server.

Changes

  • Added functionality to the ParentConnection.update() to update the NamedConnection.caption
  • Updated logic in the datasource CLI to use Datasource.connection.update() to update a connection
  • Updated test for Datasource.connection.update()
    • Removed test numbers from comments above the test

Tests

  • Ran updated test for Datasource.connection.update()

Copy link
Contributor

@jaybythebay jaybythebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JustinGrilli JustinGrilli merged commit 487f8ef into main Jul 7, 2023
1 check passed
@JustinGrilli JustinGrilli deleted the update-connection-update-logic branch July 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants