Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib #84

Merged
merged 5 commits into from
May 13, 2024
Merged

Use importlib #84

merged 5 commits into from
May 13, 2024

Conversation

jaybythebay
Copy link
Contributor

Description

On installation there were sometimes errors due to missing pkg_resources. That can be solved by pip installing setuptools. That said, using importlib to get the version removes this dependency. https://docs.python.org/3/library/importlib.html is part of the standard base Python.

Changes

  • Get version using import_lib
  • Add short flag for version
  • Remove un-needed packages

Tests

Successfully installed tableau_utilities-2.2.11
➜  tableau-utilities git:(use-importlib) ✗ tableau_utilities -v           
tableau_utilities 2.2.11
➜  tableau-utilities git:(use-importlib) ✗ tableau_utilities --version    
tableau_utilities 2.2.11

…Silicon

Move imports to IF statement to avoid error when installing on Apple Silicon

Fix docs

adjust version number:
@jaybythebay
Copy link
Contributor Author

@JustinGrilli this is ready for review. We can merge #83 first and then this one and release together.

Add new column init functionality
Copy link
Collaborator

@JustinGrilli JustinGrilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jaybythebay and others added 2 commits May 13, 2024 09:53
simplify, fix docs, reduce printing.

Co-Authored-By: Justin Grilli <37851359+JustinGrilli@users.noreply.github.com>
Add new column init functionality
@JustinGrilli JustinGrilli merged commit 41b5b8a into hoverinc:main May 13, 2024
@JustinGrilli JustinGrilli deleted the use-importlib branch May 13, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants