Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm/release-chart): update version for umbrella chart children #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neilime
Copy link
Contributor

@neilime neilime commented Jul 31, 2024

No description provided.

@neilime neilime self-assigned this Jul 31, 2024
@neilime neilime linked an issue Jul 31, 2024 that may be closed by this pull request
@neilime neilime requested a review from fredleger July 31, 2024 08:03
@neilime
Copy link
Contributor Author

neilime commented Jul 31, 2024

@fredleger it is complicated to upgrade the umbrella chart children versions.

Because if we change the version of a child, we must change the root Chart dependencies version so we must run helm dependency update (https://github.com/hoverkraft-tech/ci-github-container/actions/runs/10176351460/job/28145583710?pr=329#step:4:291)

It's not good to me because we don't have control on what we update.

What's your opinion?

@fredleger
Copy link
Contributor

That's true I didn't anticipate this point. My bad.

About the control I'm not sure, if this is a real dependency like mysql the version is locked by the semver used.

If it's one of our child deps then we know what we are updating.

Maybe I'm missing something in the picture here. Let me know.

Another way maybe to find a way to do only partial updates of lock file but I'm not sure it's even possible.

@neilime
Copy link
Contributor Author

neilime commented Jul 31, 2024

  • It seems impossible to update a specific dependency
  • Relying on semver version is dangerous as it depends which kind of version is used (By example, Helm recommends the use of version ranges - https://helm.sh/docs/chart_best_practices/dependencies/#versions)
  • The only way to me is to update the Chart.lock manually, but I dont know how (we need to reverse engineer helm) and I dont think it is a good solution

@neilime neilime force-pushed the feat/helm-release-umbrella-version branch from 786e002 to 38115ba Compare July 31, 2024 11:24
Copy link
Contributor

@fredleger fredleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think limiting it to dependencies starting with file protocol is clever and give good control over it

@neilime
Copy link
Contributor Author

neilime commented Jul 31, 2024

I think limiting it to dependencies starting with file protocol is clever and give good control over it

How can we do it?

@fredleger fredleger self-assigned this Sep 13, 2024
@neilime
Copy link
Contributor Author

neilime commented Sep 13, 2024

@fredleger should check it

@neilime neilime force-pushed the feat/helm-release-umbrella-version branch from 38115ba to 5b17097 Compare October 11, 2024 08:56
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime neilime force-pushed the feat/helm-release-umbrella-version branch from 5b17097 to 2ae6e0e Compare October 11, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports umbrella charts
2 participants