Modify Hack for Crash Tag Team Racing to fix Gundam games #9274
Conversation
Core/HLE/sceGe.cpp
Outdated
| @@ -408,6 +408,7 @@ int sceGeListSync(u32 displayListID, u32 mode) { | |||
|
|
|||
| static u32 sceGeDrawSync(u32 mode) { | |||
| //wait/check entire drawing state | |||
| hleEatCycles(500000); //HACK(?) : Potential fix for Crash Tag Team Racing and a few Gundam games | |||
There was a problem hiding this comment.
Don't like this, this seems like a dangerous change that will affect the timing of many, many games. Of course, eating a small amount of cycles here makes sense, but that big an amount would seem to indicate that the problem really is that we are processing display lists too fast, and the game is buggy and stupidly relies on that.
If we find no other sensible solution, I could accept this behind a compat flag that only turns it on for the affected games.
|
Eating small amounts didn't really helped I actually tried it even before taking value from CTTR hack, so I made it into compat.ini. |
|
if (PSP_CoreParameter().compat.flags().DrawSyncEatCycles) <<<<error Builds What? No |
|
Build warning :) |
|
Don't really see any warnings, maybe your compiler is racist against braceless statements.;p VS and most other stuff seeing what Travis already built seems to be perfectly happy with it. |
|
Alright, this is fine. It's clear that we need to improve GPU timings. |
|
@LunaMoo Not sure need include this. |
|
Don't know about any crashes in that game, there's even this english fan translation project where they definitely use ppsspp, even released some HD textures to this game aiming at texture replacement and the only crashing mentioned in their very long thread seems to be related to some HQ texture pack(not the HD one) which replaces files on iso. It should be easy enough for any user to just edit compat.ini and add new games for the existing hacks to check if it can affect it or not. |
|
It is not easy for edit compat.ini for Android. |
|
yeah, been meaning to make it also read compat.ini from PSP/SYSTEM on the stick if that exists... that would make such tests easier on Android. Though bugs that need compat workarounds are not normally android-only so you can just try on PC. |
|
Actually it was already done;p. So it should be easy for android users as well. They just need to create that file manually or copy it from ppsspp github whatever's faster, then add new game ID's under hacks they want to activate. |
|
Oh yeah, I guess that got done indeed :) |
|
What happens if we remove the hack for Gundam now that #12160 is in? -[Unknown] |
|
I'll open a new issue for that. |
This wasn't tested much yet, I don't even have Crash Tag Team Racing so maybe it's not ok for merging.
It modifies the hack for CTTR to the other function mentioned in #5468 which turns out to fix Gundam games that is: #7136, #9003 maybe also #9007 /definitely needs more testing, hence why I'm opening this pr.
So far I tested Gundam Battle Universe and Gundam Battle Chronicle with this, both seems to work, but in place of previous crash they get like 1 glitchy frame, might be caused by this or some other GE function also needing a change in pair with this. Edit: Nvm the glitch is #9275 ;p saw a difference since I updated right before building this heh.
Edit: Removed custom build as I got CTTR tested which is affected same way as before aka still fixed at least US version from the PS store, but it was potentially affecting different regions differently in the first place?
Fixes #7136, Fixes #9003
Should also fix #9007, but I can't find which Ace units crash it even without this hack, the error from the log posted looks exactly same as from other 2 gundam games through.