Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(io): consider cpp2 line ending in comment #579

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

JohelEGP
Copy link
Contributor

Resolves #563.

The comment isn't lowered to where it belongs,
so this may need some more work.

Testing summary:

100% tests passed, 0 tests failed out of 752

Total Test time (real) =  40.51 sec

Acknowledgements:

@hsutter
Copy link
Owner

hsutter commented Aug 11, 2023

LGTM, thanks!

@hsutter hsutter merged commit dc0ae62 into hsutter:main Aug 11, 2023
@JohelEGP JohelEGP deleted the cpp2-comment-cpp1_seq branch August 11, 2023 20:33
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
* test: add `mixed-bugfix-for-cpp2-comment-cpp1-sequence`

* fix(io): consider cpp2 line ending in comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Trailing comment after Cpp2 declaration can't be followed by Cpp1
2 participants