Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more granularity to ConnectionError through more specific error classes #783

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add more granularity to ConnectionError through more specific error classes #783

merged 2 commits into from
Jul 24, 2024

Conversation

omkarmoghe
Copy link
Contributor

  • would love to have more granularity into what kind of Connection error is being thrown
  • this PR changes 3/4 ConnectionError throws to use subclasses specific to that failure mode
  • this is backwards compatible because they are subclasses of ConnectionError so this should not affect any existing rescue logic
  • open to feedback!

@omkarmoghe
Copy link
Contributor Author

somewhat related to #674

@tarcieri tarcieri merged commit b74b16c into httprb:main Jul 24, 2024
6 checks passed
@ixti ixti mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omkarmoghe @tarcieri