Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TupleInf Open IE Dataset #1095

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Add TupleInf Open IE Dataset #1095

merged 4 commits into from
Dec 4, 2020

Conversation

mattbui
Copy link
Contributor

@mattbui mattbui commented Dec 4, 2020

For more information: https://allenai.org/data/tuple-ie

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this one :)

Don't forget to add the tags of the dataset card. It the yaml part at the top of the dataset card
more info here : https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md#tag-the-dataset-and-write-the-dataset-card

Also if you could describe a bit the different fields of the dataset in the Data Fields paragraph of the dataset card it would be useful. You can leave the other paragraphs as [More Information Needed]

datasets/tuple_ie/tuple_ie.py Outdated Show resolved Hide resolved
@lhoestq
Copy link
Member

lhoestq commented Dec 4, 2020

Errors are in the CI are not related to this PR (RemoteDatasetError)
the CI is fixed on master so it's fine

mattbui and others added 3 commits December 4, 2020 21:41
Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
@mattbui
Copy link
Contributor Author

mattbui commented Dec 4, 2020

@lhoestq Added the dataset card. Please let me know if more information needs to be added.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the dataset card :)

@lhoestq lhoestq merged commit c2f8e04 into huggingface:master Dec 4, 2020
ggdupont pushed a commit to ggdupont/datasets that referenced this pull request Dec 4, 2020
* Add tuple_ie dataset

* Specify custom config class

Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>

* Add dataset card

* Update README.md

Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
sileod pushed a commit to sileod/datasets that referenced this pull request Dec 7, 2020
* Add tuple_ie dataset

* Specify custom config class

Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>

* Add dataset card

* Update README.md

Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants