Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics docstrings. #1583

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Update metrics docstrings. #1583

merged 1 commit into from
Dec 18, 2020

Conversation

Fraser-Greenlee
Copy link
Contributor

#1478 Correcting the argument descriptions for metrics.

Let me know if there's any issues.

thomwolf
thomwolf approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (cc @jplu)

jplu
jplu approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@jplu jplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real term as used in the litterature is "ground truth" and not "predicted", but I'm ok to update, if this looks more understandable. LGTM!

@thomwolf thomwolf merged commit 441e204 into huggingface:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplu jplu jplu approved these changes

@thomwolf thomwolf thomwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fraser-Greenlee @jplu @thomwolf