-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] refactor tests #167
Conversation
Nice ! |
from __future__ import absolute_import | ||
from __future__ import division | ||
from __future__ import print_function | ||
from __future__ import absolute_import, division, print_function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a problem with black smh ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether that's black
or isort
, but I don't think it's a problem.
It's just that we don't check quality on the datasets
folder at the moment - see the .circle_ci folder, but I added ./datasets
to the Make style
file. So I think it's just that some people upload datasets without formatting them and I correct it :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should add ./datasets
to the circle ci quality check!
This PR separates AWS and Local tests to remove these ugly statements in the script:
To run a
aws
test, one should now run the following command:The same
local
test, can be run with: