Enable auto-download for PAN-X / Wikiann domain in XTREME #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some examples had an underscore in the third column which violated the label mapping
albertvillanova
approved these changes
May 6, 2021
There was a problem hiding this comment.
Thanks @lewtun. It is great to get rid of the manual download...
This was referenced Jul 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the manual download of the
PAN-X.langdomains with an auto-download from a Dropbox link provided by the Wikiann author. We also add the relevant dummy data for these domains.While re-generating
dataset_infos.jsonI ran into aKeyErrorin theudpos.Arabicdomain so have included a fix for this as well.