Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise FileNotFoundError in WindowsFileLock #2524

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Raise FileNotFoundError in WindowsFileLock #2524

merged 1 commit into from
Jun 28, 2021

Conversation

mariosasko
Copy link
Collaborator

Closes #2443

@lhoestq
Copy link
Member

lhoestq commented Jun 21, 2021 •
edited
Loading

Hi ! Could you clarify what it fixes exactly and give more details please ? Especially why this is related to the windows hanging error ?

@lhoestq lhoestq merged commit cda8bb0 into huggingface:master Jun 28, 2021
@mariosasko
Copy link
Collaborator Author

This has already been merged, but I'll clarify the idea of this PR. Before this merge, FileLock was the only component affected by the max path limit on Windows (that came to my notice) because of its infinite loop that would suppress errors. So instead of suppressing the FileNotFoundError that is thrown by os.open if the file name is longer than the max allowed path length, this PR reraises it to notify the user.

@mariosasko mariosasko deleted the raise-error-in-filelock branch June 28, 2021 09:56
@albertvillanova albertvillanova mentioned this pull request Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests hang on Windows
2 participants
@mariosasko @lhoestq