Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AG News dataset #316

Merged
merged 2 commits into from
Jun 30, 2020
Merged

add AG News dataset #316

merged 2 commits into from
Jun 30, 2020

Conversation

jxmorris12
Copy link
Contributor

@jxmorris12 jxmorris12 commented Jun 26, 2020 •
edited
Loading

adds support for the AG-News topic classification dataset

mariamabarham
mariamabarham reviewed Jun 26, 2020
View reviewed changes
datasets/ag_news/ag_news.py Outdated Show resolved Hide resolved
datasets/ag_news/ag_news.py Outdated Show resolved Hide resolved
@mariamabarham
Copy link
Contributor

Thanks @jxmorris12 for adding this adding.
Can you please add a small description of the PR?

patrickvonplaten
patrickvonplaten approved these changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

lhoestq
lhoestq approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) thanks !

@lhoestq lhoestq merged commit 99a02dc into huggingface:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghomasHudson ghomasHudson ghomasHudson left review comments

@mariamabarham mariamabarham mariamabarham left review comments

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jxmorris12 @mariamabarham @ghomasHudson @patrickvonplaten @lhoestq