Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asserts replaced by exceptions (huggingface#3171) #3174

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Asserts replaced by exceptions (huggingface#3171) #3174

merged 2 commits into from
Oct 29, 2021

Conversation

joseporiolayats
Copy link
Contributor

I've replaced two asserts with their proper exceptions following the guidelines described in issue #3171 by following the contributing guidelines.

PS: This is one of my first PRs, hoping I don't break anything!

lhoestq
lhoestq approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks all good to me ! thanks :)

@lhoestq lhoestq merged commit d6becb5 into huggingface:master Oct 29, 2021
@joseporiolayats joseporiolayats deleted the replace-assert-with-proper-exceptions branch October 29, 2021 16:32
@albertvillanova
Copy link
Member

Your first PR went smoothly, well done!
You are welcome to continue contributing to this project.
Gràcies, @joseporiolayats! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseporiolayats @albertvillanova @lhoestq