Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in NewsQA dataset #3734

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Fix bugs in NewsQA dataset #3734

merged 6 commits into from
Feb 17, 2022

Conversation

albertvillanova
Copy link
Member

Fix #3733.

lhoestq
lhoestq approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks ! You might need to also update the sample in the dataset card to reflect this change, as well as the documentation of the fields to account for the new ones and the removed ones

@albertvillanova albertvillanova merged commit 6103a62 into master Feb 17, 2022
@albertvillanova albertvillanova deleted the fix-3733 branch February 17, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs in NewsQA dataset
2 participants
@albertvillanova @lhoestq