Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RedCaps streamable #3737

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Make RedCaps streamable #3737

merged 1 commit into from
Feb 16, 2022

Conversation

mariosasko
Copy link
Collaborator

Make RedCaps streamable.

@lhoestq Using data/redcaps_v1.0_annotations.zip as a download URL gives an error locally when running datasets-cli test (will investigate this another time)

lhoestq
lhoestq approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Yea I think the datasets-cli test command simply doesn't work for relative paths yet. We can look into that later

@mariosasko mariosasko merged commit 5f52561 into master Feb 16, 2022
@mariosasko mariosasko deleted the make-red_caps-streamable-again branch February 16, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariosasko @lhoestq