Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow not specifying feature cols other than predictions/references in Metric.compute #3824

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Allow not specifying feature cols other than predictions/references in Metric.compute #3824

merged 4 commits into from
Mar 4, 2022

Conversation

mariosasko
Copy link
Collaborator

Fix #3818

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@mariosasko mariosasko changed the title Allow args other than predictions/references in Metric.compute Allow not specifying feature cols other than predictions/references in Metric.compute Mar 4, 2022
lhoestq
lhoestq reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks ! We might have to update the test to support this. Sorry I forgot to do it when updating the metrics logic

@mariosasko mariosasko requested a review from lhoestq March 4, 2022 17:32
lhoestq
lhoestq approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test :)

@mariosasko mariosasko merged commit e158e37 into master Mar 4, 2022
@mariosasko mariosasko deleted the fix-3818 branch March 4, 2022 18:04
@mariosasko mariosasko mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for "sources" parameter in the add() and add_batch() methods in datasets.metric - SARI
3 participants
@mariosasko @HuggingFaceDocBuilderDev @lhoestq