Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking] Rename formated to formatted #516

Merged
merged 1 commit into from
Aug 20, 2020
Merged

[Breaking] Rename formated to formatted #516

merged 1 commit into from
Aug 20, 2020

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Aug 19, 2020

formated is not correct but formatted is

lhoestq
lhoestq commented Aug 19, 2020
View reviewed changes
src/nlp/arrow_dataset.py
@@ -482,7 +482,7 @@ def format(self):
}

@contextlib.contextmanager
def formated_as(
def formatted_as(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is breaking

thomwolf
thomwolf approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol a breaking typo. Ok for that since we are renaming the in-place methods for 1.0.0 anyway :-)

@lhoestq lhoestq merged commit 230205c into master Aug 20, 2020
@lhoestq lhoestq deleted the rename-formated-to-formatted branch August 20, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwolf thomwolf thomwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhoestq @thomwolf