Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI require_beam maximum compatible dill version #5212

Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Nov 8, 2022

A previous commit to main branch introduced an additional requirement on maximum compatible dill version with apache-beam in our CI require_beam:

This PR fixes the maximum compatible dill version with apache-beam, which is <0.3.2 (and not 0.3.6): https://github.com/apache/beam/blob/v2.42.0/sdks/python/setup.py#L219

@albertvillanova albertvillanova changed the title Fix CI require_beam dill maximum compatible version Fix CI require_beam maximum compatible dill version Nov 8, 2022
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! And sorry it was my mistake ^^'

@albertvillanova albertvillanova merged commit c7b3990 into huggingface:main Nov 15, 2022
@albertvillanova albertvillanova deleted the fix-fix-require-beam branch November 15, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants