Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL guide #5223

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Add SQL guide #5223

merged 3 commits into from
Nov 15, 2022

Conversation

stevhliu
Copy link
Member

@stevhliu stevhliu commented Nov 9, 2022

This PR adapts @nateraw's awesome SQL notebook as a guide for the docs!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@nateraw
Copy link
Contributor

nateraw commented Nov 9, 2022

I think we may want more content on this page that's not SQL related. Some of that content probably already lives in the main load docs page, but might be bad to remove major things like csv/pandas from there...WDYT we should do @lhoestq ?

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @nateraw and think we should expand the existing "Load" page with more SQL examples instead of starting a new page unless there is enough content related to tabular data to put there (it seems that's not the case for now).

PS: CSV should be the preferred way to store/load tabular data IMO, due to its ease of use.

docs/source/tabular_load.mdx Outdated Show resolved Hide resolved
@lhoestq
Copy link
Member

lhoestq commented Nov 14, 2022

Maybe the main load page can only show one example and redirect to this page for more details ?

We can do the same for pandas stuff: have one example in load, and redirect to this page for more details

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks !

@stevhliu stevhliu merged commit 0c3b8fa into huggingface:main Nov 15, 2022
@stevhliu stevhliu deleted the tabular-section branch November 15, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants