-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL guide #5223
Add SQL guide #5223
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
I think we may want more content on this page that's not SQL related. Some of that content probably already lives in the main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @nateraw and think we should expand the existing "Load" page with more SQL examples instead of starting a new page unless there is enough content related to tabular data to put there (it seems that's not the case for now).
PS: CSV should be the preferred way to store/load tabular data IMO, due to its ease of use.
Maybe the main load page can only show one example and redirect to this page for more details ? We can do the same for pandas stuff: have one example in load, and redirect to this page for more details |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks !
This PR adapts @nateraw's awesome SQL notebook as a guide for the docs!