Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin fsspec #5733

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Unpin fsspec #5733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c97a503
Pass clobber True
albertvillanova Apr 11, 2023
1b6ddd9
Merge remote-tracking branch 'upstream/main' into fix-fsspec-register…
albertvillanova Apr 11, 2023
fda7ed3
Unpin fsspec
albertvillanova Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
"importlib_metadata;python_version<'3.8'",
# to save datasets locally or on any filesystem
# minimum 2021.11.1 so that BlockSizeError is fixed: see https://github.com/fsspec/filesystem_spec/pull/830
"fsspec[http]>=2021.11.1,<2023.4.0", # Temporary pin
"fsspec[http]>=2021.11.1",
# for data streaming via http
"aiohttp",
# To get datasets from the Datasets Hub on huggingface.co
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ def _strip_protocol(cls, path):
@pytest.fixture
def mock_fsspec():
original_registry = fsspec.registry.copy()
fsspec.register_implementation("mock", MockFileSystem)
fsspec.register_implementation("tmp", TmpDirFileSystem)
fsspec.register_implementation("mock", MockFileSystem, clobber=True)
fsspec.register_implementation("tmp", TmpDirFileSystem, clobber=True)
yield
fsspec.registry = original_registry

Expand Down
2 changes: 1 addition & 1 deletion tests/test_streaming_download_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def _open(
@pytest.fixture
def mock_fsspec():
original_registry = fsspec.registry.copy()
fsspec.register_implementation("mock", DummyTestFS)
fsspec.register_implementation("mock", DummyTestFS, clobber=True)
yield
fsspec.registry = original_registry

Expand Down