Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Test files locally #67

Merged
merged 6 commits into from
May 8, 2020
Merged

[Tests] Test files locally #67

merged 6 commits into from
May 8, 2020

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented May 8, 2020

This PR adds a aws and a local decorator to the tests so that tests now run on the local datasets.

By default, the aws is deactivated and local is activated and slow is deactivated, so that only 1 test per dataset runs on circle ci.

When local is activated all folders in ./datasets are tested.

Important When adding a dataset, we should no longer upload it to AWS. The steps are:

  1. Open a PR
  2. Add a dataset as described in datasets/README.md
  3. If all tests pass, push to master

Currently we have 49 functional datasets in our code base.

We have 6 datasets "under-construction" that don't pass the tests - so I put them in a folder "datasets_under_construction" - it would be nice to open a PR to fix them and put them in the datasets folder.

Important when running tests locally, the datasets are cached so to rerun them delete your local cache via:
rm -r ~/.cache/huggingface/datasets/*

@thomwolf @mariamabarham @lhoestq

@patrickvonplaten patrickvonplaten merged commit f31d8c7 into master May 8, 2020
@patrickvonplaten patrickvonplaten deleted the test_files_locally branch May 8, 2020 15:17
@thomwolf
Copy link
Member

thomwolf commented May 8, 2020

Super nice, good job @patrickvonplaten!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants