add metrec: arabic poetry dataset

[zaidalyafeai]

No description provided.

[lhoestq]

That looks awesome good job !

For the sprint that is going to begin soon, we're now asking to add one dataset card per dataset.
You can se more information in those PRs : #896 and #894

Could you create a dataset card for Metrec as well ? The goal of a dataset card is to detail the characteristics of a dataset. The content of the dataset card is going to be displayed in the huggingface.co dataset search tool :)

[zaidalyafeai]

@lhoestq removed prints and added the dataset card.

[zaidalyafeai]

@lhoestq, I want to add other datasets as well. I am not sure if it is possible to do so with the same branch.

[lhoestq]

Really nice good job :)

To add another dataset, please use a create a new branch from master and create another PR

[yjernite]

Hi @zaidalyafeai, really excited to get more Arabic coverage in the lib, thanks for your contribution!

Couple of last comments:

• this PR seems to modify some files that are unrelated to your dataset. Could you rebase from master? It should take care of that.
• The dataset card is a good start! Can you describe the task in a few words and add more information in the Data Structure part, including listing and describing the fields? Also, if you don't know how to fill out a paragraph, or if you have some information but think more would be beneficial, please leave [More Information Needed] instead of [N/A]

[zaidalyafeai]

Hi @zaidalyafeai, really excited to get more Arabic coverage in the lib, thanks for your contribution!

Couple of last comments:

• this PR seems to modify some files that are unrelated to your dataset. Could you rebase from master? It should take care of that.
• The dataset card is a good start! Can you describe the task in a few words and add more information in the Data Structure part, including listing and describing the fields? Also, if you don't know how to fill out a paragraph, or if you have some information but think more would be beneficial, please leave [More Information Needed] instead of [N/A]

I have no idea how some other files changed. I tried to rebase and push but this created some errors. I had to run the command
git push -u --force origin add-metrec-dataset which might cause some problems.

[lhoestq]

Feel free to create another branch/another PR without all the other changes

[zaidalyafeai]

@yjernite can you explain which other files are changed because of the PR ? https://github.com/huggingface/datasets/pull/893/files only shows files related to the dataset.

[lhoestq]

Right ! github is nice with us today :)

[lhoestq]

Looks like this one is ready to merge, thanks @zaidalyafeai !

[zaidalyafeai]

@lhoestq thanks for the merge. I am not a GitHub geek. I already have another dataset to add. I'm not sure how to add another given my forked repo. Do I follow the same steps with a different checkout name ?

[lhoestq]

If you've followed the instructions in here : https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md#start-by-preparing-your-environment

(especially point 2. and the command git remote add upstream ....)

Then you can try

git checkout master
git fetch upstream
git rebase upstream/master
git checkout -b add-<my-new-dataset-name>