Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OPUS DOGC dataset #987

Merged
merged 10 commits into from
Dec 4, 2020
Merged

Add OPUS DOGC dataset #987

merged 10 commits into from
Dec 4, 2020

Conversation

albertvillanova
Copy link
Member

No description provided.

@albertvillanova albertvillanova marked this pull request as ready for review December 2, 2020 15:26
lhoestq
lhoestq reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look very cool, thank you for adding this one.

Usually we use the Translation feature type for this kind of dataset, could you do this change please ?

datasets/opus_dogc/opus_dogc.py Outdated Show resolved Hide resolved
lhoestq
lhoestq approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this change !
LGTM :)

@lhoestq
Copy link
Member

lhoestq commented Dec 4, 2020

merging since the CI is fixed on master

@lhoestq lhoestq merged commit 6378ef4 into huggingface:master Dec 4, 2020
ggdupont pushed a commit to ggdupont/datasets that referenced this pull request Dec 4, 2020
@albertvillanova @yjernite @ggdupont
Add OPUS DOGC dataset (huggingface#987)
66d7a1e 
* Add OPUS DOGC dataset

* Add dummy data

* Add dataset_infos.json

* Add tags to README

* Use Translation feature

* Update dataset_infos.json

* Update datasets/opus_dogc/README.md

* Fix README

* Update README.md

Co-authored-by: Yacine Jernite <yjernite@users.noreply.github.com>
abecadel pushed a commit to abecadel/datasets that referenced this pull request Dec 4, 2020
@albertvillanova @yjernite
Add OPUS DOGC dataset (huggingface#987)
d2cd4fb 
* Add OPUS DOGC dataset

* Add dummy data

* Add dataset_infos.json

* Add tags to README

* Use Translation feature

* Update dataset_infos.json

* Update datasets/opus_dogc/README.md

* Fix README

* Update README.md

Co-authored-by: Yacine Jernite <yjernite@users.noreply.github.com>
sileod pushed a commit to sileod/datasets that referenced this pull request Dec 7, 2020
@albertvillanova @yjernite @sileod
Add OPUS DOGC dataset (huggingface#987)
0c14c5f 
* Add OPUS DOGC dataset

* Add dummy data

* Add dataset_infos.json

* Add tags to README

* Use Translation feature

* Update dataset_infos.json

* Update datasets/opus_dogc/README.md

* Fix README

* Update README.md

Co-authored-by: Yacine Jernite <yjernite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjernite yjernite yjernite left review comments

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertvillanova @lhoestq @yjernite