Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.upsample = Upsample1D #8580

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

kkj15dk
Copy link
Contributor

@kkj15dk kkj15dk commented Jun 16, 2024

What does this PR do?

I'm new to hugging face (and PR in general), will probably use diffusers for a project i'm working on, and stumbled upon this.
self.upsample was using the downsample class, not upsample. I guessing its a part of the library not many people use, so it wasn't caught.

Before submitting

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit 4408047 into huggingface:main Jun 18, 2024
14 of 15 checks passed
@yiyixuxu
Copy link
Collaborator

@kkj15dk welcome! and thanks for your contribution:) it's a good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants