Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tuple format in combine evaluations #604

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −2
Open

Support tuple format in combine evaluations #604

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c44d43
add test
shunk031 Jun 28, 2024
39a76ed
improve evaluation module handling
shunk031 Jun 28, 2024
e7091d8
remove last line
shunk031 Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add test
  • Loading branch information
@shunk031
shunk031 committed Jun 28, 2024
commit 8c44d43661579cd4d20d9b9414c61db799f1298c
16 changes: 15 additions & 1 deletion tests/test_metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pytest
from datasets.features import Features, Sequence, Value

from evaluate.module import EvaluationModule, EvaluationModuleInfo, combine
from evaluate.module import CombinedEvaluations, EvaluationModule, EvaluationModuleInfo, combine

from .utils import require_tf, require_torch

Expand Down Expand Up @@ -757,3 +757,17 @@ def test_modules_from_string_poslabel(self):
self.assertDictEqual(
expected_result, combined_evaluation.compute(predictions=predictions, references=references, pos_label=0)
)


@pytest.mark.parametrize(
"evaluations,",
(
[DummyMetric(), DummyMetric()],
(DummyMetric(), DummyMetric()),
{"metric1": DummyMetric(), "metric2": DummyMetric()},
),
)
def test_combine_evaluations_in_different_forms(evaluations):
combined_evaluation = combine(evaluations)
assert isinstance(combined_evaluation, CombinedEvaluations)