Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flax] Align GLUE training script with mlm training script #11778

Merged

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented May 19, 2021

What does this PR do?

Currently running on TPUv3-8 to see if this leads to a speed-up

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten patrickvonplaten changed the title [Flax] speed up flax glue [WIP][Flax] speed up flax glue May 19, 2021
@patrickvonplaten
Copy link
Contributor Author

patrickvonplaten commented May 20, 2021

Ran the experiment again, but testing time stayed the same for me...think it's better though to have a consistent way of handling the random keys though - so merging

@patrickvonplaten patrickvonplaten changed the title [WIP][Flax] speed up flax glue [Flax] Align GLUE training script with mlm training script May 20, 2021
@patrickvonplaten patrickvonplaten merged commit bd98716 into huggingface:master May 21, 2021
@patrickvonplaten patrickvonplaten deleted the speed_up_run_flax_glue branch May 21, 2021 08:37
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
…ce#11778)

* speed up flax glue

* remove unnecessary line

* remove folder

* remove run in loop

Co-authored-by: Patrick von Platen <patrick@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants