Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate commands from the transformers-cli that are in the hf-cli #11779

Merged
merged 1 commit into from
May 20, 2021

Conversation

LysandreJik
Copy link
Member

Commands that are both in the transformers-cli and in the huggingface-cli are deprecated here and will be quickly removed.

I'm voting for deprecating them and not removing them even though better ways exist as I suspect some users to use the transformers-cli in bash scripts to automatically upload models to the hub.

Context from @julien-c:

my thoughts is that we should deprecate the subset of transformers-cli command that are in huggingface-cli, as the commands are identical and having both is confusing.

Transformers-specific commands (model conversion, new model templating) can stay in transformers-cli.

What do you think?

@julien-c
Copy link
Member

my reason for removing (still keeping a descriptive error obviously) rather than deprecating is that I'd love to know if people actually use those (and if they do, do they use them in scripts or manually)

But I will defer to the great transformers-maintainers as the final decision 💖

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will know for sure after people ignore the deprecation warnings and complain in v5 when we actually remove them ;-)
But we go to convoluted lengths to avoid breaking changes in situations way smaller than this, so I feel very strongly about going through the normal deprecation cycle and wait for a major release before removing.

@julien-c
Copy link
Member

sounds good to me!

@LysandreJik LysandreJik merged commit 075fdab into master May 20, 2021
@LysandreJik LysandreJik deleted the deprecate-cli branch May 20, 2021 07:16
Iwontbecreative pushed a commit to Iwontbecreative/transformers that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants