replace Speech2TextTokenizer by Speech2TextFeatureExtractor in some docstrings
#16835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Apr 19, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
…me docstrings (huggingface#16835) * replace `Speech2TextTokenizer` by `Speech2TextFeatureExtractor` in docstring * quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It seems to me that fbank features can be returned by an
FeatureExtractorand not by aTokenizer. This PR proposes to make some changes in the docstrings that mention thatSpeech2TextTokenizershould be used to return fbank features.It seems to me that among the 3 models -
Speech2Text,Speech2Text2andSpeechEncoderDecoder- onlySpeech2Textimplements a feature extractor and I therefore deduce that the same feature extractor class that is used for the 3 models.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. As it concerns audio related model, I would love to have your feedback @patrickvonplaten , @anton-l or @patil-suraj