Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch 1.12.0 for scheduled CI #17949

Merged
merged 1 commit into from
Jun 29, 2022
Merged

PyTorch 1.12.0 for scheduled CI #17949

merged 1 commit into from
Jun 29, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 29, 2022

What does this PR do?

After the slack discussion, using PyTorch 1.12.0 for scheduled CI is a better idea, so we can see what to fix.

Another reason is that this (messy) block

RUN [ ${#PYTORCH} -gt 0 ] && VERSION='torch=='$PYTORCH'.*' || VERSION='torch'; python3 -m pip install --no-cache-dir -U $VERSION --extra-index-url https://download.pytorch.org/whl/cu113
RUN [ ${#TORCH_VISION} -gt 0 ] && VERSION='torchvision=='TORCH_VISION'.*' || VERSION='torchvision'; python3 -m pip install --no-cache-dir -U $VERSION --extra-index-url https://download.pytorch.org/whl/cu113
RUN [ ${#TORCH_AUDIO} -gt 0 ] && VERSION='torchaudio=='TORCH_AUDIO'.*' || VERSION='torchaudio'; python3 -m pip install --no-cache-dir -U $VERSION --extra-index-url https://download.pytorch.org/whl/cu113

will change torch 1.11 (if specified) back to 1.12, as torchvision and torchaudio are installed separately from torch without specifying versions. It's better to avoid such situations.

Regarding the torch/torchvision/torchaudio correspondence, I have better approach in my past-ci PR.

@ydshieh ydshieh requested review from sgugger and stas00 June 29, 2022 17:10
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 29, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh changed the title PyTorch 1.12.0 PyTorch 1.12.0 for scheduled CI Jun 29, 2022
@ydshieh ydshieh merged commit b089cca into main Jun 29, 2022
@ydshieh ydshieh deleted the use_pytorch_1.12.0 branch June 29, 2022 17:32
viclzhu pushed a commit to viclzhu/transformers that referenced this pull request Jul 18, 2022
Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants