Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate: validate model_kwargs (and catch typos in generate arguments) #18261

Merged
merged 8 commits into from
Aug 12, 2022
Merged

Generate: validate model_kwargs (and catch typos in generate arguments) #18261

merged 8 commits into from
Aug 12, 2022

Commits on Jul 22, 2022

  1. validate generate model_kwargs

    @gante
    gante committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    1142e04 View commit details
    Browse the repository at this point in the history

  2. better comments

    @gante
    gante committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    0a75fe2 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Merge branch 'main' into validate_kwargs

    @gante
    gante authored Aug 5, 2022
    Configuration menu
    Copy the full SHA
    03633e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. add PR suggestions

    @gante
    gante committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    855e1f4 View commit details
    Browse the repository at this point in the history

  2. fix transfoxl generation tests (no attention mask)

    @gante
    gante committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0749966 View commit details
    Browse the repository at this point in the history

  3. manual merge with main

    @gante
    gante committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ba4ab22 View commit details
    Browse the repository at this point in the history

  4. generate tests -- not all models have an attn mask

    @gante
    gante committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    97b6f9d View commit details
    Browse the repository at this point in the history

  5. fix a few more tests

    @gante
    gante committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    92f7072 View commit details
    Browse the repository at this point in the history