unpin torch to use 1.12.1 #18514
Closed
unpin torch to use 1.12.1 #18514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
|
Here are the tests to fix before we can use 1.12.1
|
|
Most tapas tests will likely work given @sgugger's PR above, as it's probably linked to the version of the torch-scatter dependency |
|
Yes! Thanks, @LysandreJik |
|
(guess I can close this PR, and just merge #17925) |
ydshieh
commented
Aug 8, 2022
| @@ -187,6 +187,8 @@ def backward(ctx, grad_output): | |||
|
|
|||
| @staticmethod | |||
| def symbolic(g: torch._C.Graph, input: torch._C.Value, local_ctx: Union[float, DropoutContext]) -> torch._C.Value: | |||
| from torch.onnx import symbolic_opset12 | |||
There was a problem hiding this comment.
Without this line, we get (for torch 1.12.x):
FAILED tests/onnx/test_onnx_v2.py::StableDropoutTestCase::test_training - AttributeError: module 'torch.onnx' has no attribute 'symbolic_opset12'
ydshieh
commented
Aug 8, 2022
| @@ -193,6 +193,8 @@ def backward(ctx, grad_output): | |||
|
|
|||
| @staticmethod | |||
| def symbolic(g: torch._C.Graph, input: torch._C.Value, local_ctx: Union[float, DropoutContext]) -> torch._C.Value: | |||
| from torch.onnx import symbolic_opset12 | |||
There was a problem hiding this comment.
Just applied the same change
ydshieh
commented
Aug 8, 2022
| @@ -597,6 +597,8 @@ def backward(ctx, grad_output): | |||
|
|
|||
| @staticmethod | |||
| def symbolic(g: torch._C.Graph, input: torch._C.Value, local_ctx: Union[float, DropoutContext]) -> torch._C.Value: | |||
| from torch.onnx import symbolic_opset12 | |||
|
Can you push necessary changes directly on #17925 (I'm too lazy to check this PR contains the same fixes as this one 😅 ) The branch is |
|
Close this and work on #17925 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
unpin torch to use 1.12.1