Revert to rescale and safely handle flag in owlvit config #18750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
alaradirik
approved these changes
Aug 24, 2022
Comment on lines
+91
to
+94
| if "rescale" in kwargs: | ||
| rescale_val = kwargs.pop("rescale") | ||
| kwargs["do_rescale"] = rescale_val | ||
|
|
There was a problem hiding this comment.
Looks good! Will we eventually remove this part?
There was a problem hiding this comment.
Yes. I think we can leave it for a short period of time so that if anyone pushes to the hub and updates the model, pushing the feature extractor with it, then the rescale parameter will be renamed in the preprocessor_config.json. After that, we could add a warning if rescale is in detected in the config - asking the person to update their config as it will no longer be supported as a flag in the future.
LysandreJik
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Perfect! Thanks for handling the backwards compatibility @amyeroberts
oneraghavan
pushed a commit
to oneraghavan/transformers
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reverts the
rescale_imagemethod name to back torescale. This keeps the method inline with other method names such asnormalize.This undoes the renaming in #18677 done to address failing tests caused by
rescalekey being in OWL-ViT config and the introduction of arescalemethod in #18499.The OWL-ViT config has since been updated. As the model has been released, we rename the key in the config in case
rescaleis there for backwards compatibility.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.