Use assertAlmostEqual
in BloomEmbeddingTest.test_logits
#19200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
BloomEmbeddingTest.test_logits
currently usesassertEqual
to compare 2 floats. We should instead useassertAlmostEqual
.Currently we don't see this test failing. However, with different PyTorch versions, we might get test failure - this happens for Past CI (PyTroch 1.10), where we got
AssertionError: 1.9311904907226562e-05 != 1.9431114196777344e-05