Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstall torch_tensorrt in DeepSpeed CI image for now #20758

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 13, 2022

What does this PR do?

Since we update CI to use PyTorch 1.13, it uses a base image nvcr.io/nvidia/pytorch:22.04-py3 which contains torch_tensorrt.
This causes the CI failing from the test collection - i.e. the whole test suite fails from the beginning.

This PR uninstalls torch_tensorrt for now (previously, this is not installed for DeepSpeed CI - the stable release version), so at least the CI could run (and to see if any test would fail with PyTorch 1.13).

We will have to work on the torch_tensorrt issue though.

Current error message

==================================== ERRORS ====================================
______________ ERROR collecting tests/deepspeed/test_deepspeed.py ______________
ImportError while importing test module '/workspace/transformers/tests/deepspeed/test_deepspeed.py'.

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you, @ydshieh!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 13, 2022

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh changed the title Uninstall torch_tensorrt in DeepSpeed CI image` for now Uninstall torch_tensorrt in DeepSpeed CI image for now Dec 13, 2022
@ydshieh ydshieh merged commit d994473 into main Dec 13, 2022
@ydshieh ydshieh deleted the fix_deepspeed_test branch December 13, 2022 21:25
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
…ce#20758)

Uninstall torch_tensorrt for now

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
venkat-natchi pushed a commit to venkat-natchi/transformers that referenced this pull request Jan 22, 2023
…ce#20758)

Uninstall torch_tensorrt for now

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
…ce#20758)

Uninstall torch_tensorrt for now

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
@ydshieh ydshieh mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants