Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[setup] migrate setup script to pyproject.toml #22539

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Apr 3, 2023

What does this PR do?

Follows discussion in #22531 (comment)

Changes:

  • migrate setup script to pyproject.toml
  • migrate pytest configs to pyproject.toml
  • cleanup isort and flake8 configs

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 3, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Will double check that the package data keeps to be included. Other than that flagged one difference.

long_description=open("README.md", "r", encoding="utf-8").read(),
long_description_content_type="text/markdown",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are losing those apparently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes to project.readme in pyproject.toml. The content type will be inferred from the extension (.md or .rst).

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and can confirm all extra files are still included in the build. Thanks for your PR!

@sgugger sgugger merged commit 4169dc8 into huggingface:main Apr 3, 2023
@XuehaiPan XuehaiPan deleted the pyproject branch April 4, 2023 06:48
raghavanone pushed a commit to raghavanone/transformers that referenced this pull request Apr 5, 2023
* [setup] migrate setup script to `pyproject.toml`

* [setup] cleanup configurations

* remove unused imports
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* [setup] migrate setup script to `pyproject.toml`

* [setup] cleanup configurations

* remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants