-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[setup] migrate setup script to pyproject.toml
#22539
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Will double check that the package data keeps to be included. Other than that flagged one difference.
long_description=open("README.md", "r", encoding="utf-8").read(), | ||
long_description_content_type="text/markdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are losing those apparently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It goes to project.readme
in pyproject.toml
. The content type will be inferred from the extension (.md
or .rst
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and can confirm all extra files are still included in the build. Thanks for your PR!
* [setup] migrate setup script to `pyproject.toml` * [setup] cleanup configurations * remove unused imports
* [setup] migrate setup script to `pyproject.toml` * [setup] cleanup configurations * remove unused imports
What does this PR do?
Follows discussion in #22531 (comment)
Changes:
pyproject.toml
pytest
configs topyproject.toml
isort
andflake8
configsBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.