Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert migration of setup to pyproject.toml #22658

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Revert migration of setup to pyproject.toml #22658

merged 1 commit into from
Apr 7, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Apr 7, 2023

What does this PR do?

As mentioned in #22599, the migration of the setup to pyproject is causing some issues for editable installs on some setups. This PR reverts that migration and adds the setup.py to the formatted files. (Note that I could not directly revert the original PR due to some of its changes being already reverted in #22587 )

Fixes #22599

@sgugger sgugger requested a review from LysandreJik April 7, 2023 17:51
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 7, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @sgugger

@sgugger sgugger merged commit 6db23af into main Apr 7, 2023
@sgugger sgugger deleted the revert_setup branch April 7, 2023 19:08
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'transformers' after installing from source
3 participants