Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow protobuf 3.20.3 requirement #22759

Merged
merged 6 commits into from
May 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions
  • Loading branch information
ydshieh committed May 10, 2023
commit e643fe74e8e34b01867ae0c5c0a7b513c5249408
27 changes: 2 additions & 25 deletions tests/test_tokenization_common.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run 2 tests in a subprocess to avoid problematic core dump

Original file line number Diff line number Diff line change
Expand Up @@ -156,29 +156,6 @@ def _test_subword_regularization_tokenizer(in_queue, out_queue, timeout):
out_queue.join()


def _test_pickle_subword_regularization_tokenizer(in_queue, out_queue, timeout):
error = None

try:
inputs = in_queue.get(timeout=timeout)
tokenizer_new = inputs["tokenizer_new"]
sp_model_kwargs = inputs["sp_model_kwargs"]
test_sentencepiece_ignore_case = inputs["test_sentencepiece_ignore_case"]

unittest.TestCase().assertTrue(hasattr(tokenizer_new, "sp_model_kwargs"))
unittest.TestCase().assertIsNotNone(tokenizer_new.sp_model_kwargs)
unittest.TestCase().assertTrue(isinstance(tokenizer_new.sp_model_kwargs, dict))
unittest.TestCase().assertDictEqual(tokenizer_new.sp_model_kwargs, sp_model_kwargs)
check_subword_sampling(tokenizer_new, test_sentencepiece_ignore_case=test_sentencepiece_ignore_case)

except Exception:
error = f"{traceback.format_exc()}"

results = {"error": error}
out_queue.put(results, timeout=timeout)
out_queue.join()


def check_subword_sampling(
tokenizer: PreTrainedTokenizer,
text: str = None,
Expand Down Expand Up @@ -534,9 +511,9 @@ def test_pickle_subword_regularization_tokenizer(self) -> None:

run_test_in_subprocess(
test_case=self,
target_func=_test_pickle_subword_regularization_tokenizer,
target_func=_test_subword_regularization_tokenizer,
inputs={
"tokenizer_new": tokenizer_new,
"tokenizer": tokenizer_new,
"sp_model_kwargs": sp_model_kwargs,
"test_sentencepiece_ignore_case": self.test_sentencepiece_ignore_case,
},
Expand Down