Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with non Python files #23405

Merged
merged 3 commits into from
May 16, 2023
Merged

Build with non Python files #23405

merged 3 commits into from
May 16, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented May 16, 2023

What does this PR do?

It appears the non python files (such as CUDA kernesl) have disappeared from the built package once again. Fir some reason there were found before with just *.extension, but now need **/*.extension (although once found again I can remove the **).

This is all super brittle, so this PR also adds:

  • a check that the build package contains the non-Python files before we upload it on testpypi
  • a check that the library installed does contain the non-Python files before we upload it on pypi

Will make a patch after this is merged.

@sgugger sgugger requested a review from LysandreJik May 16, 2023 15:37
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 16, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and script!

@sgugger sgugger merged commit 9cf4a8b into main May 16, 2023
@sgugger sgugger deleted the build_with_custom_files branch May 16, 2023 18:23
sgugger added a commit that referenced this pull request May 16, 2023
* Add a test of the built release

* Polish everything

* Trigger CI
sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
* Add a test of the built release

* Polish everything

* Trigger CI
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* Add a test of the built release

* Polish everything

* Trigger CI
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* Add a test of the built release

* Polish everything

* Trigger CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants