Fix transformers' DeepSpeed CI job
#23463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
May 19, 2023
| @@ -26,6 +26,9 @@ RUN python3 -m pip install --no-cache-dir ./transformers[deepspeed-testing] | |||
|
|
|||
| RUN python3 -m pip install --no-cache-dir git+https://github.com/huggingface/accelerate@main#egg=accelerate | |||
|
|
|||
| # Uninstall `transformer-engine` shipped with the base image | |||
| RUN python3 -m pip uninstall -y transformer-engine | |||
There was a problem hiding this comment.
wasn't in the previous base docker image (cu117)
|
The documentation is not available anymore as the PR was closed or merged. |
|
Going to merge. cc @stas00 so you know now we are using CUDA 118 on CI (as you mentioned/requested once before) |
|
super! thank you for the heads up, @ydshieh! |
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The new (cu118) base docker image has pre-installed
transformer-engine(which wasn't the case in the previous base image). This causes DeepSpeed CI job fails from the beginning withThis PR uninstall
transformer-engineso @ydshieh won't be the breaking bad.