Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove add-new-model in favor of add-new-model-like #30424

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Apr 23, 2024

This PR removes the very outdated add_new_model script (that wasn't working correctly anymore) in favor of the add_new_model_like script that is favored.

@amyeroberts @ArthurZucker

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this removed ❤️

@LysandreJik
Copy link
Member Author

Thanks both!

@LysandreJik LysandreJik merged commit d4e92f1 into main Apr 24, 2024
8 checks passed
@LysandreJik LysandreJik deleted the remove-add-new-model branch April 24, 2024 07:38
itazap pushed a commit that referenced this pull request May 14, 2024
* Remove add-new-model in favor of add-new-model-like

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants