Fix fx tests with inputs_embeds #31862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The remaining 2 failures in |
amyeroberts
reviewed
Jul 9, 2024
|
@fxmarty Any update on this? This is still causing failures on |
|
Thanks a lot @amyeroberts, could you give it a second look? |
amyeroberts
approved these changes
Jul 11, 2024
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
* fix tests * [test_all] check * address review comments
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
* fix tests * [test_all] check * address review comments
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
* fix tests * [test_all] check * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more tests were failing following #31840, CI was not triggered, this time making sure locally that
pytest tests/models/ -s -vvvvv -k "test_torch_fx"passes.