Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a code of conduct #7433

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add a code of conduct #7433

merged 1 commit into from
Sep 29, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 28, 2020

What does this PR do?

This PR adds a code of conduct to the project, inspired by the Contributor Covenant. To make it clearly visible it also adds:

  • a badge that displays under Transformers on the main README.
  • a link in the contributing guide.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #7433 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7433      +/-   ##
==========================================
- Coverage   76.85%   76.84%   -0.02%     
==========================================
  Files         181      181              
  Lines       35800    35800              
==========================================
- Hits        27513    27509       -4     
- Misses       8287     8291       +4     
Impacted Files Coverage Δ
src/transformers/tokenization_t5.py 66.34% <0.00%> (-28.85%) ⬇️
src/transformers/file_utils.py 83.37% <0.00%> (+0.24%) ⬆️
src/transformers/tokenization_mbart.py 96.82% <0.00%> (+39.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a8ffa...f8d87a2. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition. Thanks for adding it!

Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@julien-c
Copy link
Member

(before merging, let's check out the thread we had internally on this)

@sgugger sgugger merged commit f1220c5 into master Sep 29, 2020
@sgugger sgugger deleted the code_of_conduct branch September 29, 2020 17:38
thevasudevgupta pushed a commit to thevasudevgupta/transformers that referenced this pull request Sep 29, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants