Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #8968 #9009

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fixes #8968 #9009

merged 1 commit into from
Dec 9, 2020

Conversation

cronoik
Copy link
Contributor

@cronoik cronoik commented Dec 9, 2020

This is the same PR as: link. I was asked to create a new one due to a merge mistake.

What does this PR do? (Text of the previous PR)

One of the 3.X releases introduced output objects that replaced the previously returned tuples. This PR updates the transformers notebook to reflect that update.

Fixes #8968

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@patrickvonplaten
@LysandreJik

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickvonplaten patrickvonplaten merged commit 8729109 into huggingface:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

02-transformery.ipynb - output from model only strings 'last_hidden_state', 'pooler_output'
2 participants